search

nbia-astro / skeletor

Parallel PIC code written in Python and based on the skeleton codes provided by PICKSC
GNU General Public License v3.0
1 stars 0 forks source link

Fix tests #72

Closed tberlok closed 7 years ago

tberlok commented 7 years ago

This turns the code into a 2.5 hybrid code.

The magnetic field is implemented to be colocated but staggered along x and y. All other quantities are cell centered.

The new examples are

  1. example/fastwave.py
  2. example/circular.py

Changes we might want to add before merging this in:

  1. At the moment Ohm's law only works with second order finite differences.
  2. real2_t Float2 and so on should be renamed to real3_t Float3.
  3. Some of the tests have been moved to broken_tests. This is probably not acceptable but I just spend 3.5 hours fixing tests, so it will have to wait...
tobson commented 7 years ago

Can we talk about this on Skype? I have time at around 3 o'clock.

tberlok commented 7 years ago

Sounds good to me. I only have until 16.10 though.

2017-02-21 13:23 GMT+01:00 Tobias Heinemann notifications@github.com:

Can we talk about this on Skype? I have time at around 3 o'clock.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nbia-astro/skeletor/pull/72#issuecomment-281330472, or mute the thread https://github.com/notifications/unsubscribe-auth/AKKVoOxx97MAmUqseXMmTjleB-lA9Ezzks5retc9gaJpZM4MHG3C .

--

Thomas Berlok, PhD Student

Niels Bohr Institute Theoretical Astrophysics Group Blegdamsvej 17, office 01-2-Bc8 DK-2100 Copenhagen Denmark

e-mail: berlok@nbi.dk