search

nbj / cockroachdb-laravel

CockroachDB database driver for Laravel 5
MIT License
57 stars 17 forks source link

Lumen 8 compatibility #23

Open HimanshuM opened 3 years ago

HimanshuM commented 3 years ago

Tested on Lumen version 7 & 8 Following error is thrown: Declaration of Nbj\Cockroach\Grammar\Query\CockroachGrammar::compileUpdateColumns($values) must be compatible with Illuminate\Database\Query\Grammars\Grammar::compileUpdateColumns(Illuminate\Database\Query\Builder $query, array $values) This can be fixed by changing the prototype of the method.

Elycin commented 3 years ago

Confirming this issue is present.

  ErrorException 

  Declaration of Nbj\Cockroach\Grammar\Query\CockroachGrammar::compileUpdateColumns($values) should be compatible with Illuminate\Database\Query\Grammars\Grammar::compileUpdateColumns(Illuminate\Database\Query\Builder $query, array $values)

  at C:\Users\elyci\PhpstormProjects\project\vendor\nbj\cockroachdb-laravel\src\Cockroach\Grammar\Query\CockroachGrammar.php:127
    123▕      *
    124▕      * @param  array   $values
    125▕      * @return string
    126▕      */
  ➜ 127▕     protected function compileUpdateColumns($values)
    128▕     {
    129▕         // When gathering the columns for an update statement, we'll wrap each of the
    130▕         // columns and convert it to a parameter value. Then we will concatenate a
    131▕         // list of the columns that can be added into this update query clauses.

I'll see if I can open a PR for this.

leenooks commented 2 years ago

This appears to be in master with 626613a - so probably could be closed?