nbkhope
commented
3 months ago 1) You should have created a feature branch first before working on the feature. Then commit to that feature branch and make a pull request using that branch.
git checkout -b add-more-dog-pictures
# ... do your work ...
git push origin add-more-dog-picturesI'll let it pass for this pull request (PR).
2) Regarding the automatic code formatter. Put yourself in the shoes of a code reviewer, you see a lot of diff noise https://github.com/nbktechworld/full-stack-web-dev/pull/61/files. It's going to take longer to review.
From the point of view of focused pull requests relevant to the issue, you should try to change code that is only relevant to your task. Avoid touching code that is unrelated. Refrain and resist the urge from performing cosmetic changes just because you think it is pretty (even if it wasnt "you" and was performed with automatic format on save). The codebase should remains as is.
So I'd recommend you not use code formatter please. Only touch the code that is relevant to your issue.
Oleksii-Poltavets
Hi, I've added two pictures with dogs on them besides the Dalmatian as a comment in the issue asked to do. I also gave the image attribute height='100' to make them all be one height, my prettier automatically changed some spaces in the code and in most cases fixed the position of tags let me know if it's ok.