search

nblockchain / conventions

MIT License
1 stars 10 forks source link

subject-full-stop false positive #132

Open knocte opened 1 year ago

knocte commented 1 year ago

When title ends with ... then subject-full-stop fails. We should probably fix this in commitlint (upstream).

knocte commented 1 year ago

https://github.com/nblockchain/conventions/actions/runs/5676281095/job/15382851282

tehraninasab commented 1 year ago

What should be the logic? accepting 3 dots at the end of commit title?

knocte commented 1 year ago

I think that subject-full-stop should only fail if last character is a dot, but if previous-to-last character is not a dot.

tehraninasab commented 1 year ago

What should be the rule's behavior if its config was set to 'always' use a dot at the end of the title instead of never?

knocte commented 1 year ago

If the title ends with "...", commitlint's subect-full-stop rule should never fail, regardless if it's 'always' or 'never'.