Closed tehraninasab closed 1 year ago
@Mersho @parhamsaremi a commit titled "apply comments" might be easily understood when it is pushed after a PR review has happened; but if you look at the git history of a repository, without the context of a PR, it's very easy to ask yourself the question "what comments?" "a comment can be applied?". You understand my point? Let's fix this commit msg to not be confusing please.
@Mersho CI is still red
@Mersho CI is red because it's failed to install nodejs
I don't have access to re-run CI, do you think I should re-push?
installing : node-v18.17.1
mkdir : /usr/local/n/versions/node/18.17.1
fetch : https://nodejs.org/dist/v18.17.1/node-v18.17.1-linux-x64.tar.gz
curl: (92) HTTP/2 stream 0 was not closed cleanly: INTERNAL_ERROR (err 2)
gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
Error: failed to download archive for 18.17.1
Error: Process completed with exit code 1.
I don't have access to re-run CI,
Ask Zahra to give you access. The telegram channel is meant for this king of things.
do you think I should re-push?
Next time you face a problem like this, just repush while you wait for someone to give you perms; you shouldn't need to depend on me for this kind of small things :)
Next time you face a problem like this
BTW, I say "Next time" because I'm going to re-run that CI now, but this shouldn't mean that you don't need to ask for Zahra's perms anymore.
@Mersho the next CI issue might be a permissions problem because Zahra changed her username, I think. Let's workaround this by just opening a new PR from your account.
Working on https://github.com/nblockchain/conventions/issues/122.