search

nblockchain / fsx

FSX is the ideal tool for people that use F# for their scripting needs.
MIT License
14 stars 5 forks source link

Tests: moved tests from testTsv.fs to unit tests #20

Closed webwarrior-ws closed 1 year ago

webwarrior-ws commented 1 year ago

Reorganized tests from testTsv.fs file as unit tests in Fsdk.Tests project.

knocte commented 1 year ago

@webwarrior-ws good work; I might leave this open for a bit until I double-check if other tests need to be moved or not.

In the meantime, if you finish the NOnion&geewallet PRs to adopt Fsdk's FSharpUtil, next thing to do would be to create a PR in this fsx repo to remove all Async.RunSynchronously calls from Fsdk (the consequence of this is that some functions will start returning Async<Foo> instead of Foo, and the side-effect is that you might need to change some scripts that make use of these functions to call Async.RunSynchronously in them).

Thanks

knocte commented 1 year ago

@webwarrior-ws let's move the AsyncCancellation tests from geewallet to this PR too please. I think I created them when I was working on some AsyncExtensions functions, so they should belong here.

knocte commented 1 year ago

New changes since you last viewed Merge branch 'nblockchain:master' into move-tsv-test

What is this? Please don't push merge commits to PRs.

knocte commented 1 year ago

What is this? Please don't push merge commits to PRs.

Rebasing PRs needs to be done with git rebase or git cherry-pick, not git merge.

knocte commented 1 year ago

Rebasing PRs needs to be done with git rebase or git cherry-pick, not git merge.

On top of that, I never asked you to rebase this PR, so please don't rebase when it's not necessary.

webwarrior-ws commented 1 year ago

Reverted that merge. I think merge occurred because I clicked "sync fork" on github.