search

nblockchain / fsx

FSX is the ideal tool for people that use F# for their scripting needs.
MIT License
14 stars 5 forks source link

Timing test still flakey #25

Closed knocte closed 1 year ago

knocte commented 1 year ago

@webwarrior-ws , we received another failure here: https://github.com/nblockchain/fsx/actions/runs/4012299515/jobs/6890632917 , I thought you had fixed this in this commit? Why did it fail again?

webwarrior-ws commented 1 year ago

I chose error margin (5ms) based on previous failed runs. It turns out that sometimes that margin is not enough and needs to be increased.

knocte commented 1 year ago

What was the error margin in this instance?

webwarrior-ws commented 1 year ago

5.6571 ms

webwarrior-ws commented 1 year ago

^ that was deviation from expected result. Error margin is still 5ms.

knocte commented 1 year ago

Ok I'll increase it to 10ms, thanks.