nblockchain / fsx

FSX is the ideal tool for people that use F# for their scripting needs.
MIT License
14 stars 5 forks source link

Misc: allow unknown args when finding prefix #38

Closed aarani closed 10 months ago

knocte commented 10 months ago

I shouldn't have merged it because you were missing the why, sigh. Please write the why here.

knocte commented 10 months ago

ping

aarani commented 10 months ago

I shouldn't have merged it because you were missing the why, sigh. Please write the why here.

There's no reason for a code that's supposed to search arguments for a prefix, to limit or even care about other arguments. We needed to accept other arguments besides "prefix" in one of our scripts and this code would throw and this commit fixes that.

knocte commented 10 months ago

There's no reason for a code that's supposed to search arguments for a prefix, to limit or even care about other arguments, this commit fixes that.

And why do you need it to not care about other arguments? Please state the ultimate why @aarani

aarani commented 10 months ago

There's no reason for a code that's supposed to search arguments for a prefix, to limit or even care about other arguments, this commit fixes that.

And why do you need it to not care about other arguments? Please state the ultimate why @aarani

edited*