nblockchain / geewallet

geewallet is a non-custodial, minimalistic & pragmatist opensource crossplatform lightweight brainwallet to hold the most important cryptoassets in the same application with ease & peace of mind
MIT License
61 stars 37 forks source link

Maui first steps #199

Closed parhamsaremi closed 1 year ago

parhamsaremi commented 1 year ago

TODO:

knocte commented 1 year ago
parhamsaremi commented 1 year ago
  • I still see the currency images, when we agreed to remove them because they are not used.
  • The renaming of files in the 2nd commit is not related to what the commit title says.

I fixed these and some more problems.

knocte commented 1 year ago

add Maui base project

Titles start with uppercase (everywhere, not just in commit messages; you know, book titles, e-mail titles, etc). Also, if this commit is using a template, point the URL to that template in the commit message body.

But most important of all: the commit doesn't pass CI.

parhamsaremi commented 1 year ago

Sorry I forgot to answer this. Yes I'm aware of the problem. I was working on it.

parhamsaremi commented 1 year ago

Titles start with uppercase (everywhere, not just in commit messages; you know, book titles, e-mail titles, etc). Also, if this commit is using a template, point the URL to that template in the commit message body.

Great I wasn't sure what I should put in the body. thanks.

parhamsaremi commented 1 year ago

@knocte I made CI green for both commits. Somehow when I click on the details link, it shows me that it's red for Windows and Macos but in my branch, it shows that they are green.

knocte commented 1 year ago

Today I saw this on twitter: https://twitter.com/runfaster2000/status/1620962106421161984 maybe we should add a ubuntu2210 lane for building Maui app on vanilla OS, mmm.

aarani commented 1 year ago

Commit msg for b02fb589dba3b0718a5829631a1fec1977164dff can be expanded by stating why you changed some layouts, why you kept the old ones and didn't change them as well etc

knocte commented 11 months ago

@Mersho please rebase this PR (new PR based on the current master branch, with the commits here cherry-picked)

knocte commented 11 months ago

Superseded by https://github.com/nblockchain/geewallet/pull/241