search

nblockchain / geewallet

geewallet is a non-custodial, minimalistic & pragmatist opensource crossplatform lightweight brainwallet to hold the most important cryptoassets in the same application with ease & peace of mind
MIT License
61 stars 37 forks source link

Frontend.XF.GTK: different exitCode on root #257

Open Mersho opened 6 months ago

Mersho commented 6 months ago

The snap package generated from the GitHub artifact has been tested and it works well:

mkdir: cannot create directory ‘/run/user/0’: Permission denied
realpath: '': No such file or directory
realpath: '': No such file or directory
realpath: '': No such file or directory
realpath: '': No such file or directory
realpath: '': No such file or directory
realpath: '': No such file or directory
realpath: '': No such file or directory
realpath: '': No such file or directory

Unhandled Exception:
System.Exception: Running as root user is not supported
  at GWallet.Frontend.XF.Gtk.Main.main (System.String[] argv) [0x00020] in <65dc7568944123fea74503836875dc65>:0 
[ERROR] FATAL UNHANDLED EXCEPTION: System.Exception: Running as root user is not supported
  at GWallet.Frontend.XF.Gtk.Main.main (System.String[] argv) [0x00020] in <65dc7568944123fea74503836875dc65>:0
knocte commented 6 months ago

This commit msg sucks because:

Frontend.XF.GTK: exit with one when user is root

With "one"? are you serious???? What is "one"??? Sigh. Please say exitCode different than zero, or something like that. And also update PR title and description whenever you change commit msg!!

update.go:85: cannot change mount namespace according to change mount (/snap/gtk-common- themes/1534/share/gtk2/Materia-compact /snap/geewallet/x1/data-dir/themes/Materia-compact none bind,ro 0 0): cannot write to "/snap/gtk-common-themes/1534/share/gtk2/Materia-compact" because it would affect the host in "/snap" update.go:85: cannot change mount namespace according to change mount (/snap/gtk-common- themes/1534/share/gtk2/Materia-dark-compact /snap/geewallet/x1/data-dir/themes/Materia-dark-compact none bind,ro 0 0): cannot write to "/snap/gtk-common-themes/1534/share/gtk2/Materia-dark-compact" because it would affect the host in "/snap" update.go:85: cannot change mount namespace according to change mount (/snap/gtk-common-themes/1534/share/gtk2/Yaru-MATE-dark /snap/geewallet/x1/data-dir/themes/Yaru-MATE-dark none bind,ro 0 0): cannot use "/snap/gtk-common-themes/1534/share/gtk2/Yaru-MATE-dark" as bind-mount source: not a directory update.go:85: cannot change mount namespace according to change mount (/snap/gtk-common-themes/1534/share/gtk2/Yaru-MATE-light /snap/geewallet/x1/data-dir/themes/Yaru-MATE-light none bind,ro 0 0): cannot use "/snap/gtk-common-themes/1534/share/gtk2/Yaru-MATE-light" as bind-mount source: not a directory mkdir: cannot create directory ‘/run/user/0’: Permission denied realpath: '': No such file or directory realpath: '': No such file or directory realpath: '': No such file or directory realpath: '': No such file or directory realpath: '': No such file or directory realpath: '': No such file or directory realpath: '': No such file or directory realpath: '': No such file or directory Authorization required, but no authorization protocol specified

(geewallet:5797): Gtk-WARNING **: 09:01:13.760: cannot open display: :0

I think the majority of this gibberish that you pasted above is ALSO being printed when the user is not root, so please TRIM the gibberish to only the important error that makes this shit crash.

Mersho commented 6 months ago

If you rerun the CI, it will be green. ty 🙏