search

nblockchain / geewallet

geewallet is a non-custodial, minimalistic & pragmatist opensource crossplatform lightweight brainwallet to hold the most important cryptoassets in the same application with ease & peace of mind
MIT License
61 stars 37 forks source link

FeeRates proposed by Electrum servers (BTC) are abnormally high #272

Open knocte opened 6 months ago

knocte commented 6 months ago

I noticed this in many occassions. An example was that I was given about 200 sat/vB while mempool.space was suggesting a range around [50-70] at most.

Maybe we have wrong a units conversion issue? In case we don't, we should probably mitigate this issue by having 2 sources more of estimation: 1) https://mempool.space/api/v1/fees/recommended 2) https://api.blockchain.info/mempool/fees

So we should treat all 3 as same authority (the 3rd one being the average between some electrum servers, which is the only source we have in master branch now). But instead of doing an average of the 3, we should probably do an average of the 2 closest ones, to prevent outliers. Example for this algorithm is here: c5530e2cc7d28669a1513310a84efee768c74108 (in particular, https://github.com/nblockchain/geewallet/commit/c5530e2cc7d28669a1513310a84efee768c74108#diff-334c23b77817534a6745af372d0f1f2b4512ef053d679909a5e8471ae278c301R1096 )