nblockchain / geewallet

geewallet is a non-custodial, minimalistic & pragmatist opensource crossplatform lightweight brainwallet to hold the most important cryptoassets in the same application with ease & peace of mind
MIT License
61 stars 37 forks source link

MAUI: first steps #274

Closed webwarrior-ws closed 5 months ago

webwarrior-ws commented 6 months ago

Supersedes #241

webwarrior-ws commented 6 months ago

Added "Upload APK as CI artifact" step

knocte commented 6 months ago

In PR241, the 1st commit passes CI (it's green), but not here. I think when you pushed on Thursday EOD, it was also green here, but something you must have changed today to not be green anymore.

knocte commented 6 months ago

UI nits I found:

Screenshot 2024-04-23 at 4 01 40 PM
knocte commented 6 months ago

I tried debugging the Android MAUI app in VS4Mac today and it seems to hang after submitting the payment password (it never goes to next page: loadingPage). Have you tested the Android MAUI app?

webwarrior-ws commented 6 months ago

Yes. Android MAUI app was fine for me. I can clear data and launch the app to see if it hangs after submitting payment password.

webwarrior-ws commented 6 months ago

As for UI: I think style should be modified to fix things like no margins around buttons and input fields not distinguishable from background.

knocte commented 6 months ago

Yes. Android MAUI app was fine for me. I can clear data and launch the app to see if it hangs after submitting payment password.

Nevermind, it worked for me in the end; it was not hanging, just extremely slow. We'll look into this later.

Another thing I've noticed wrt UI that needs to be fixed (is not a nit):

Screenshot 2024-04-23 at 4 14 52 PM

See? ReceivePage doesn't have a "back" button.

knocte commented 6 months ago

I think style should be modified to fix things like no margins around buttons and input fields not distinguishable from background.

What do you mean?

knocte commented 6 months ago
Screenshot 2024-04-23 at 4 19 08 PM

More from above:

knocte commented 6 months ago

Some separation between currency dropdown and amount textbox.

Also separation between "Amount:" label and "Not enough funds" label.

webwarrior-ws commented 6 months ago

The problem with textboxes is that they are basically invisible. For example, in previous screenshot there is input field below "Destination address:" label, but you can't see it. They same is for input field right to the "Password:".

webwarrior-ws commented 6 months ago

ReceivePage didn't have any extra back button. But you can always use standard Android back button or gesture.

knocte commented 6 months ago

The problem with textboxes is that they are basically invisible. For example, in previous screenshot there is input field below "Destination address:" label, but you can't see it. They same is for input field right to the "Password:".

I know that, why are you rephrasing the problem that I already described? I'm saying that we discussed this in the past (but not just the problem but we discussed solutions).

knocte commented 6 months ago

ReceivePage didn't have any extra back button. But you can always use standard Android back button or gesture.

what??? the point of using navigation is to have those buttons automatically. Don't we have this in RIM or DG?

knocte commented 6 months ago

what??? the point of using navigation is to have those buttons automatically. Don't we have this in RIM or DG?

See https://learn.microsoft.com/en-us/dotnet/maui/user-interface/pages/navigationpage?view=net-maui-8.0 (the "back button)

webwarrior-ws commented 6 months ago

I checked, and indeed we use navigation in GWallet, but no toolbar is shown for some reason. I'll investigate.

knocte commented 6 months ago

Don't we have this in RIM or DG?

Confirmed, it is in DG, after pressing button "Add event".

knocte commented 6 months ago

@webwarrior-ws so, summary for today's priority list (items are the top should be done earlier, bottom to be done later): 1) Fix root cause of MauiGtk bug jumping label (in order to get rid of the workaround) in CrossMaui (Mali). More details above. 2) Create a CI job called snap_alpha that uploads the Maui+Gtk app as a snap package. This job should upload the snap package to snap store directly. As you don't have permissions to upload binaries to my snaps, use a different snap name: geeMauiPreview, for now. 3) Resume work on Android's toolbar's back button crash, by trying to upgrade again to Maui8 (dropping the PkgRef as I told you in telegram).

Thanks

knocte commented 5 months ago

These two commits should obviously be squashed too:

knocte commented 5 months ago

Superseded by https://github.com/nblockchain/geewallet/pull/279