search

nblumhardt / autofac-serilog-integration

Contextual logger injection for Autofac using Serilog
Apache License 2.0
70 stars 25 forks source link

Support Autofac6 #40

Closed krajek closed 4 years ago

krajek commented 4 years ago

Fixes #39. Please review the code since this is the first time I worked with the internals of Autofac :-). Commented out code is for now left, for easier reference.

krajek commented 4 years ago

FYI: I have run this version of the package on my semi-large project and it worked perfectly.

krajek commented 4 years ago

Hi @nblumhardt , thanks for the review, code is fixed.

Please merge #41 before this one if possible.

Additionally, should I adjust the readme, to make sure consumers understand the implications of updating AutofacSerilogIntegration?

nblumhardt commented 4 years ago

@krajek thanks! I think supporting the latest Autofac with a major version bump in this package will be unsurprising, so let's leave the README for now. The package itself documents its dependencies accurately.