nbnuk / nbnatlas-issues

Issue tracking for NBN Atlases
https://nbnatlas.org
2 stars 0 forks source link

Custom and full DwC download coordinateUncertaintyInMeters processed #694

Closed sophiathirza closed 5 years ago

sophiathirza commented 5 years ago

In the full and custom DwC download the 'coordinateUncertaintyInMeters processed' value should be the generalised value for sensitive records, regardless of whether the user has access or not. At the moment, if the user has access to the record the supplied value is used.

NB: the 'decimalLatitude processed' and 'decimalLongitude processed' values are the generalised values for sensitive records, regardless of the users access.

sophiathirza commented 5 years ago

I don't think that this is so important as the decimalLatitude and decimalLongitude values are generalised values. I have reduced the priority.

reupost commented 5 years ago

Fixed on 7 March

sophiathirza commented 5 years ago

The 'coordinateUncertaintyInMeters processed' is the generalised value for sensitive records in the full DwC download but it is still the supplied value in the custom DwC downloads

reupost commented 5 years ago

Ok, this should be better now. I've left the original coordinateUncertainty next to the decimalLatitude/Longitude and geodeticDatum columns, removed the misleading coordinateUncertaintyInMeters_processed value (which was displaying the unprocessed value) and made sure the sensitive columns include both.

reupost commented 5 years ago

Ok, I've removed both - see #695

sophiathirza commented 5 years ago

Have I understood correctly that we shouldn't have coordinateUncertaintyInmeters_processed?

reupost commented 5 years ago

Could you send me links to the searches you've done that show these problems please? My go-to test dataset has been deleted

reupost commented 5 years ago

When I do a Dwc download of https://records.nbnatlas.org/occurrences/search?q=lutra%20lutra&fq=month:%2204%22#tab_chartsView (having given myself sensitive access on some of these records) I get column headings

decimalLatitude processed decimalLongitude processed Longitude - ungeneralised Latitude - ungeneralised Locality - ungeneralised Grid reference - ungeneralised Coordinate uncertainty (m) - ungeneralised Coordinate uncertainty - processed

A custom download of the same set gives headings:

Longitude - ungeneralised Latitude - ungeneralised Locality - ungeneralised Grid reference - ungeneralised Coordinate uncertainty (m) - ungeneralised Coordinate uncertainty - processed

(please note these are columns GZ - HE)

Could you advise where the problems are?

sophiathirza commented 5 years ago

The fields are no longer called * - generalised.

I thought that you had removed the * - processed and kept the original names. I misunderstood - I get the same as above now.

thanks.