search

nbody6ppgpu / Nbody6PPGPU-beijing

This is Nbody6++GPU, an N-body star cluster simulation code, maintained by Rainer Spurzem and team.
14 stars 16 forks source link

Dev #9

Closed jnunosiles1 closed 1 year ago

jnunosiles1 commented 2 years ago

Dear Rainer, Kaiwu,

As you are aware from the Nbody meetings, I have been working on implementing the hyperbolic gravitational waves radiation case. This is the request to merge with your dev-branch so further trials can be made to ensure it's working properly and not prompting unexpected errors. Please do not hesitate to contact me in any case! I'm more than willing to keep on contributing to the code in whichever task I can.

Thanks, Jose Francisco

spurzem commented 2 years ago

 Dear Jose, thanks very much; I will check this asap, but please give me a few days,

 best wishes, Rainer

On 11/10/22 10:29 AM, jnunosiles1 wrote:

Dear Rainer, Kaiwu,

As you are aware from the Nbody meetings, I have been working on implementing the hyperbolic gravitational waves radiation case. This is the request to merge with your dev-branch so further trials can be made to ensure it's working properly and not prompting unexpected errors. Please do not hesitate to contact me in any case! I'm more than willing to keep on contributing to the code in whichever task I can.

Thanks, Jose Francisco

    You can view, comment on, or merge this pull request online at:

https://github.com/kaiwu-astro/Nbody6PPGPU-beijing/pull/9 https://github.com/kaiwu-astro/Nbody6PPGPU-beijing/pull/9

    Commit Summary

(3 files https://github.com/kaiwu-astro/Nbody6PPGPU-beijing/pull/9/files)

— Reply to this email directly, view it on GitHub https://github.com/kaiwu-astro/Nbody6PPGPU-beijing/pull/9, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA22M65K5DSSYOYKPTNXVDWHS573ANCNFSM6AAAAAAR4K4RQI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

Rainer Spurzem, apl. Prof. (Univ. Heidelberg), Research Professor (NAOC/CAS) Astronomisches Rechen-Institut, Zentrum für Astronomie (ZAH-ARI) Mönchhofstr. 12-14, 69120 Heidelberg, Germany AND National Astronomical Observatories, Chinese Academy of Sciences, Beijing https://wwwstaff.ari.uni-heidelberg.de/spurzem/ ; http://silkroad.bao.ac.cn

Phone: Office Munich: +49 89 82080944 ; Office Beijing: currently inactive @. @. http://silkroad.bao.ac.cn

The Kavli Institute for Astronomy and Astrophysics at Peking University

In the beginning the universe was created. This has made a lot of people very angry and been widely regarded as a bad move. (Douglas Adams)

jnunosiles1 commented 2 years ago

Dear Rainer,

Thank you for your email. Of course, no rush! Please don't hesitate to reach out if you have any questions or need any additional information that might help with the assessment.

Thanks again!

Best, Jose Francisco

El vie, 11 nov 2022 a las 12:12, Rainer Spurzem @.***>) escribió:

Dear Jose, thanks very much; I will check this asap, but please give me a few days,

best wishes, Rainer

On 11/10/22 10:29 AM, jnunosiles1 wrote:

Dear Rainer, Kaiwu,

As you are aware from the Nbody meetings, I have been working on implementing the hyperbolic gravitational waves radiation case. This is the request to merge with your dev-branch so further trials can be made to ensure it's working properly and not prompting unexpected errors. Please do not hesitate to contact me in any case! I'm more than willing to keep on contributing to the code in whichever task I can.

Thanks, Jose Francisco

You can view, comment on, or merge this pull request online at:

https://github.com/kaiwu-astro/Nbody6PPGPU-beijing/pull/9 https://github.com/kaiwu-astro/Nbody6PPGPU-beijing/pull/9

Commit Summary

Update tides3.f

Update kstide.f

Update ksint.f

File Changes

(3 files < https://github.com/kaiwu-astro/Nbody6PPGPU-beijing/pull/9/files>)

(83)

(26)

(56)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/kaiwu-astro/Nbody6PPGPU-beijing/pull/9, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAA22M65K5DSSYOYKPTNXVDWHS573ANCNFSM6AAAAAAR4K4RQI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

--

============================================================================ Rainer Spurzem, apl. Prof. (Univ. Heidelberg), Research Professor (NAOC/CAS) Astronomisches Rechen-Institut, Zentrum für Astronomie (ZAH-ARI) Mönchhofstr. 12-14, 69120 Heidelberg, Germany AND National Astronomical Observatories, Chinese Academy of Sciences, Beijing https://wwwstaff.ari.uni-heidelberg.de/spurzem/ ; http://silkroad.bao.ac.cn

Phone: Office Munich: +49 89 82080944 ; Office Beijing: currently inactive @. @. http://silkroad.bao.ac.cn

The Kavli Institute for Astronomy and Astrophysics at Peking University

In the beginning the universe was created. This has made a lot of people very angry and been widely regarded as a bad move. (Douglas Adams)

============================================================================

— Reply to this email directly, view it on GitHub https://github.com/nbody6ppgpu/Nbody6PPGPU-beijing/pull/9#issuecomment-1311561657, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQSLXN6IB4WANQYXLA6HN23WHYSZ7ANCNFSM6AAAAAAR4K4RQI . You are receiving this because you authored the thread.Message ID: @.***>

kaiwu-astro commented 1 year ago

Dear @spurzem , it seems this contrubution by Jose half a year ago is still waiting for your approval. It may be a good chance to take a look now since we plan to make a new stable version.

You can view the code change at https://github.com/nbody6ppgpu/Nbody6PPGPU-beijing/pull/9/commits , and if it's OK, click approve then Merge pull request at https://github.com/nbody6ppgpu/Nbody6PPGPU-beijing/pull/9

Anyway, it's no problem if you are busy and would like to postpone reviewing this PR.

spurzem commented 1 year ago

Hi, sorry for delay, we can develop the final form later together, but it should be merged now, thanks Jose for your work!