nborrmann / jodel_api

Unoffical Python Interface to the Jodel API
MIT License
150 stars 33 forks source link

Changed/Fixed test_post_details(_v3) #42

Closed Thamos closed 6 years ago

Thamos commented 7 years ago

As mentioned in https://github.com/nborrmann/jodel_api/pull/41 "test_post_details" doesn't work anymore.

I removed the failing part and recreated the tested functionality (check if the actual replies equal the number in the "child_count" variable) in test_post_details_v3. Sometimes this still fails, I think that happens when someone just commented. That's why I changed it to don't check the most discussed jodel.

I think the old test doesn't work anymore because if there are too many replies they don't get returned with the v2 method. -> Tested it with a 10 reply post and it worked, children array was filled -> Tested it with a > 40 reply post and it didn't work, children array was empty

I've also added the hmac key change in this pull request because otherwise the tests fail anyway.

codecov-io commented 7 years ago

Codecov Report

Merging #42 into master will decrease coverage by 2.75%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   94.88%   92.12%   -2.76%     
==========================================
  Files           6        6              
  Lines         508      508              
==========================================
- Hits          482      468      -14     
- Misses         26       40      +14
Impacted Files Coverage Δ
src/jodel_api/jodel_api.py 89.23% <100%> (-2.25%) :arrow_down:
src/jodel_api/gcmhack.py 87.09% <0%> (-7.26%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9f5d461...5eb4ccc. Read the comment docs.