nborrmann / jodel_api

Unoffical Python Interface to the Jodel API
MIT License
149 stars 33 forks source link

Added option to get jodel key and version from environment variables. #70

Open wetterfroschdus opened 6 years ago

wetterfroschdus commented 6 years ago

This allows people to keep using jodel_api without having to wait for an update. I also added a version check, so jodel_api will prefer using the newer version over older versions. This way, people don't have to worry about having old keys in their environment variables.

Oh and I also added the newest Key and Version.

codecov-io commented 6 years ago

Codecov Report

Merging #70 into master will decrease coverage by 4.68%. The diff coverage is 35.71%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #70      +/-   ##
=======================================
- Coverage   94.68%   90%   -4.69%     
=======================================
  Files           6     6              
  Lines         508   520      +12     
=======================================
- Hits          481   468      -13     
- Misses         27    52      +25
Impacted Files Coverage Δ
src/jodel_api/jodel_api.py 84.68% <35.71%> (-6.8%) :arrow_down:
src/jodel_api/gcmhack.py 87.09% <0%> (-6.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca29453...fc9f5b7. Read the comment docs.

nknappe commented 6 years ago

Hello, Unfortunately, the adjustment does not work. With 4.84.1 you get the error 477 again.

wetterfroschdus commented 6 years ago

Mhm works for me, can you walk me through the steps you took?

wetterfroschdus commented 6 years ago

Also, the checks aren't working anymore, because Jodel seems to return empty objects for unverified accounts now. So even for read-only access, you have to verify the account now.

Daedra223 commented 6 years ago

@wetterfroschdus do you know how it is possible to verify the account? Using the methods mentioned here doesnt work ...

hedgeback commented 6 years ago

Hello @wetterfroschdus

I am having the same issue with that 477 Error. The question might be getting old. I updated the jodel_api to 1.2.12 with all the changes to the version and secrets. However, I just found out the newest version of Jodel is already version 4.92.2. Do you have any idea how I might get in possession of such? I would appreciate any help. Thanks already.

wetterfroschdus commented 6 years ago

Try this.