Add some tests for backend

nbrabant / rpi-inventory

3 stars 3 forks source link

Add some tests for backend #25

Closed dangenendt closed 2 years ago

dangenendt commented 2 years ago

Hey! While upgrading laravel in the last PR i wished there would have been some tests to execute for finding issues easier and faster. I think this would be great. Perhabs another good Hacktoberfest issue.

Greetings!

nbrabant commented 2 years ago

Hey! Yes, i am always open for some good test 🙂 What is the scope you purpose? Unit, integration or end-to-end testing?

dangenendt commented 2 years ago

I think everything would be great. Depends on the class / function you want to test. But first i think some integration tests, to test the api, would be great

dangenendt commented 2 years ago

So, like those: https://laravel.com/docs/9.x/http-tests

nbrabant commented 2 years ago

I see a good use case for test and scope event usage :

Product quantity updating

Check product initial quantity -> GET api/products/{id}
Add products to cart -> POST api/cartproducts
Close cart -> PATCH api/carts/{id} --data {finished: true}
Check product new quantity is initial + cart product line quantity -> GET api/products/{id}

Feel free to explore and purpose another :+1:

dangenendt commented 2 years ago

@nbrabant Can you assign this one to me? I will do some testing. Long time ago that i write tests in laravel. Many things changed to the good (at least it looks like) <3