Closed dangenendt closed 2 years ago
@nbrabant Why did you revert several things related to the upgrade? Do you have any issues with the application? Let me know Currenlty the changes in the database-classes are not compatible with laravel 9
Hello, I think i was too tireed and sick yesterday, and i forget the important rule "don't rebase when you're sick" before rebasing the branch :/ The project master seems ok, i will check if migration execution are OK (for now, there are no problem on the project CI)
"don't rebase when you're sick"
Hahaha... yeah. Didnt know that but thats probably true To be honest, the first thing i learned about git and particular "rebase" (~2013) was "DO NOT REBASE!! UNDER NO CIRCUMSTANCES! THIS CAN BREAK EVERYTHING". And yeah... with this in mind we are nearly in the year 2023 and i didnt rebased one single time 😆
To be clear: i dont say that rebase has no right to exist, but you have to be very careful 😇
@nbrabant What should we do with this? Do i need to "repair" the branch and bring it to the "correct state"
To be clean with the history, the best strategy is recreating a new branch and cherry-pick the readme update IMO
Promise, i definitively stop rebasing ^^
Closed - will be recreated
Updated several things in readme to have an up-to-date guideline