search

nbrosowsky / tonejs-instruments

A small instrument sample library with quick-loader for tone.js
Other
408 stars 105 forks source link

Add to NPM #11

Open realmayus opened 4 years ago

realmayus commented 4 years ago

It would be great if the library would be added to NPM so that it's easy to use in e.g. react.

sarahBuisson commented 4 years ago

just for info, it would take very little effort to do so:

I did it in 5 minute for my lib

probityrules commented 2 years ago

I tried a pass at this, but I ran into issues, I think, due to the size of this repo as a dependency. Looking at what fontsource has done with the similar issue of a huge font library, I created a fork of this project that splits each instrument into its own package, as well as a package for each audio type, so the instrument dependency only includes the audio files necessary for a given implementation.

I went ahead and registered a few of these packages on NPM just to make sure the full process works, although it might be better to have this repo represented on npm's registry, not a fork.

artiphishle commented 11 months ago

Maybe you are interested to use the free space you get with GitLFS?

If you already use this space or if the free disk space isn't enough (haven't checked but they just added some more free space for everyone end of september) I could understand not wanting to pay.

However IMO we shouldn't put such amounts of data to github directly, if everyone would do so, there wouldn't be free repos anymore I assume (but keep it until we solved this please hehe)

However it's worth to have this library nice and up-to-date, and as I anyway started to pay for more GitLFS space recently, I could do it too, however this would mean that I fork the project, but as you doesn't seem to have a lot time ATM (update dates and issue reply time) it's maybe the best way.

Or, you could grant me admin access as a collaborator then I'm happy to continue with/for you.

@probityrules yout opinion please? This would also affect your work, but then audio files would be at gitlfs, we could also use a mix of your approach and this package here. Are you interested in bringing it to the next level? or/and help me in my DAW project, check it out too please, code will get properly refactored in a bit, it was plenty of work the 3 months I'm on it, so there are some restructurings planned. (on it now)