search

nbs-system / naxsi

NAXSI is an open-source, high performance, low rules maintenance WAF for NGINX
GNU General Public License v3.0
4.8k stars 606 forks source link

comment and code inconsistency: handler set in REWRITE phase, not ACCESS phase #435

Closed mlakes-sigsci closed 6 years ago

mlakes-sigsci commented 6 years ago

Comment for setting the handler says it will be set for the ACCESS phase: https://github.com/nbs-system/naxsi/blob/master/naxsi_src/naxsi_skeleton.c#L356 But the code actually sets handler for REWRITE phase - which should be ok - but what is the intention?

buixor commented 6 years ago

Nice catch, changing the comment right away :)