search

nbs-system / naxsi

NAXSI is an open-source, high performance, low rules maintenance WAF for NGINX
GNU General Public License v3.0
4.8k stars 606 forks source link

Changes to strncpy() to remove compile warnings with Ubuntu 20.04 LTS… #492

Closed marcinguy closed 4 years ago

marcinguy commented 4 years ago

…. Source is controlled, so no need for strncpy()

Tested with Nginx-1.18.0 and NAXSI-0.56

marcinguy commented 4 years ago

Please review @buixor

petecooper commented 4 years ago

https://github.com/nbs-system/naxsi/pull/492/commits/0cda8686d4dc2c06db563335934527dc09bf3b3b works for me.

Tested with Nginx 1.17.9 + Naxsi 0.56 on Ubuntu 20.04.

Thank you @marcinguy - best wishes to you!

$ sudo nginx -V
nginx version: nginx/1.17.10 (2020-04-28T12:22:26+00:00)
built by gcc 9.3.0 (Ubuntu 9.3.0-10ubuntu2) 
built with OpenSSL 1.1.1g  21 Apr 2020
TLS SNI support enabled
configure arguments: --add-dynamic-module=../../brotli-source/ --add-dynamic-module=../../cache-purge-source/ngx_cache_purge-2.5 --add-dynamic-module=../../headers-more-source/headers-more-nginx-module-0.33 --add-dynamic-module=../../ipscrub-source/ipscrub-1.0.1/ipscrub --add-dynamic-module=../../length-hiding-source/nginx-length-hiding-filter-module-1.1.1 --add-dynamic-module=../../naxsi-source/naxsi-0.56/naxsi_src --add-dynamic-module=../../openresty-memcached-source/memc-nginx-module-0.19 --add-dynamic-module=../../openresty-redis2-source/redis2-nginx-module-0.15 --add-dynamic-module=../../srcache-source/srcache-nginx-module-0.31 --add-dynamic-module=../../pagespeed-source/incubator-pagespeed-ngx-1.13.35.2-stable --add-dynamic-module=../../vts-source/nginx-module-vts-0.1.18 --build=2020-04-28T12:22:26+00:00 --conf-path=/etc/nginx/nginx.conf --error-log-path=/var/log/nginx/nginx/nginx.error.log --http-client-body-temp-path=/var/cache/nginx/client_temp --http-fastcgi-temp-path=/var/cache/nginx/fastcgi_temp --http-log-path=/var/log/nginx/nginx/nginx.access.log --http-proxy-temp-path=/var/cache/nginx/proxy_temp --lock-path=/var/run/nginx.lock --modules-path=/usr/lib/nginx/modules --pid-path=/var/run/nginx.pid --prefix=/etc/nginx --sbin-path=/usr/sbin/nginx --with-cc-opt='-m64 -march=native -mtune=native -DTCP_FASTOPEN=23 -g -O3 -fstack-protector-strong -flto -ffat-lto-objects -fuse-ld=gold --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wimplicit-fallthrough=0 -Wno-deprecated-declarations -fcode-hoisting -Wp,-D_FORTIFY_SOURCE=2' --with-compat --with-file-aio --with-http_geoip_module=dynamic --with-http_addition_module --with-http_dav_module --with-http_gunzip_module --with-http_gzip_static_module --with-http_image_filter_module=dynamic --with-http_realip_module --with-http_secure_link_module --with-http_slice_module --with-http_ssl_module --with-http_stub_status_module --with-http_sub_module --with-http_v2_module --with-http_xslt_module=dynamic --with-ld-opt='-Wl,-E -lrt -ljemalloc -lpcre -Wl,-z,relro' --with-libatomic --with-openssl-opt='shared no-ssl2 no-ssl3 no-weak-ssl-ciphers -fstack-protector-strong' --with-openssl=../../openssl-source/openssl-OpenSSL_1_1_1g --with-pcre-jit --with-pcre=../../pcre-source/pcre-8.44 --with-stream --with-stream_ssl_module --with-stream_ssl_preread_module --with-stream=dynamic --with-threads --with-zlib=../../zlib-source/zlib-1.2.11 --without-http_empty_gif_module --without-http_scgi_module --without-http_ssi_module --without-http_uwsgi_module --without-mail_imap_module --without-mail_pop3_module --without-mail_smtp_module