nbs-system / naxsi

NAXSI is an open-source, high performance, low rules maintenance WAF for NGINX
GNU General Public License v3.0
4.8k stars 606 forks source link

libinjection issue #602

Closed eilandert closed 2 years ago

eilandert commented 2 years ago

Hi @wargio

Thanks for creating the new repo.

I was not able to make debian packages, the build fails on libinjection. I removed libinjection from the tree and copied the last git version from https://github.com/libinjection/libinjection, after that it went smoothly.

Hopefully my build will be tested soon, if there are any issues, we will let you know.

note: the issues on the new repo are turned off so I noted it here.

wargio commented 2 years ago

nice to know, did you git submodule init ?

eilandert commented 2 years ago

Oh didn't think of that duh, I've a buildsystem which should take care of that. Haven't had a problem with the originally naxsi so it slipped my mind. Will try it soon.

I'm very happy that we can compile NGINX with pcre2 now.

By the way, our packages are on https://deb.myguard.nl/nginx-modules/ (and https://launchpad.net/~eilander/+archive/ubuntu/nginx), if the tests are ok I'll build a new release with the new naxsi included.

test-packages are being built and uploaded as we speak on http://edge.deb.myguard.nl:8888/pool/main/n/nginx/

wargio commented 2 years ago

Nice, if you want you can submit a PR with the missing files to build a deb file within naxsi

wargio commented 2 years ago

also the origina naxsi had embedded the libinjection files as copies, since we are in 2022 i thought to just use git features which allows to fix any possible vulnerability by just updating commits of the libinjection repository

eilandert commented 2 years ago

also the origina naxsi had embedded the libinjection files as copies, since we are in 2022 i thought to just use git features which allows to fix any possible vulnerability by just updating commits of the libinjection repository

That;s the way it should be, thank you for maintaining/update this project