search

nbsp-team / MaterialFilePicker

Picking files since 2015
Apache License 2.0
1.14k stars 229 forks source link

File type / file extension filter #9

Closed lgallard closed 8 years ago

lgallard commented 8 years ago

I would be great to have a way to filter file types by extension, for example: .pdf, .jpg

Thanks in advance!

jaymoh commented 8 years ago

it is awesome, could you please implement a way to filter files too...

dimorinny commented 8 years ago

Look at README and update library to version 1.04.

lgallard commented 8 years ago

Thanks it works like a charm!

jaymoh commented 8 years ago

Thanks so much @dimorinny , the library works really fine, although wouldn't you have compiled with android support library version 23.1.1? as the latest version 23.2 still has bugs causing apps to crash, that are being fixed by Google devs. You could email me directly, if updating the library again is quite a task.

lgallard commented 8 years ago

I got this error report from my app in Google Apps, can be this related to @jaymoh comment?

Caused by: android.content.res.Resources$NotFoundException: File res/drawable-v19/abc_ic_ab_back_material.xml from drawable resource ID #0x7f020016
lgallard commented 8 years ago

I had to switch to aFileChooser :(

dimorinny commented 8 years ago

I'll try to fix it tommorow.

lgallard commented 8 years ago

HI @dimorinny, I was trying for two days updating SDK, BuildTools, but 23.2.0 really crashes my app in Android 4.4 (maybe lower versions are affected as well, but I got reports from Google Console for 4.4). Chrashes are due to this. But even using the suggested fix other issues arise.

I use aFileChooser as my last resort, but to be hostnes it's look and feel is "old-fashion". I really like you MaterialFilePicker because it uses Material Design.

Please if you can test your library in a 4.4 it would be great, if not I can test it and give you feedback.

Regards,

lukaville commented 8 years ago

I've downgraded appcompat support library. Maybe it fixed this issue.

jaymoh commented 8 years ago

am greatful @lukaville , lemme test it right away, I was still still using 1.3

jaymoh commented 8 years ago

hi @lukaville Is it possible you downgrade even the RecyclerView library to 23.1.1 also, just all of them. For now I can't risk using 23.2 anytime soon, it has caused me enough stress since i tried upgrading in android studio.

lukaville commented 8 years ago

Ok, I've downgraded all support libraries, check out new version.

lgallard commented 8 years ago

@lukaville it works with library version 1.0.7 on devices with Android 4.4 and lower.