search

nbudin / devise_cas_authenticatable

CAS authentication support for Devise
MIT License
285 stars 117 forks source link

Undefined method destroy_session for Cache Store #137

Closed tomascharad closed 7 years ago

tomascharad commented 7 years ago

Hi @nbudin ,

I think since Rails 5, Cache store changed the method destroy_session for delete_session.

http://api.rubyonrails.org/v4.0.13/classes/ActionDispatch/Session/CacheStore.html#method-i-destroy_session

http://api.rubyonrails.org/v5.1.1/classes/ActionDispatch/Session/CacheStore.html#method-i-delete_session

https://github.com/nbudin/devise_cas_authenticatable/blob/8737a287f0078b7c02f2deba431ff5a78a2dc7f1/lib/devise_cas_authenticatable/single_sign_out.rb#L31

Could we update this?

nbudin commented 7 years ago

Looks right - thanks for letting me know! I'll have it check which one it responds to, in order to maintain backwards compatibility.

nbudin commented 7 years ago

This is now fixed in version 1.10.1.

tomascharad commented 7 years ago

Many thanks!