nbudin / devise_openid_authenticatable

OpenID authentication for Devise
MIT License
99 stars 32 forks source link

Update Rails & Devise Gems #14

Closed msaffitz closed 12 years ago

msaffitz commented 12 years ago

Bumps rails to 3.2 and devise to 2.1. Specs pass, no further validation completed.

nbudin commented 12 years ago

Hi Matt - I'd rather not bump the gem requirement to 2.1.0 or higher. Instead perhaps let's change the dependency to say >= 1.3?

glongman commented 12 years ago

bump. What's the outcome here? My 3.2 app is pegged at Devise 2.1.2 which means I can't use this gem. Is there a plan to move to Devise 2+ compatibility in the foreseeable future?

thanks Geoff

nbudin commented 12 years ago

@glongman: I've just done a commit that relaxes the version requirements. Could you try updating to the latest from git in your project and let me know if things seem to be working for you?

glongman commented 12 years ago

My day is done but will do asap.

Geoff

Sent from my mobile device.

On 2012-09-24, at 4:01 PM, Nat Budin notifications@github.com wrote:

@glongman: I've just done a commit that relaxes the version requirements. Could you try updating to the latest from git in your project and let me know if things seem to be working for you?

— Reply to this email directly or view it on GitHub.

glongman commented 12 years ago

Alas, simply bumping the gem dependency is not sufficient to get a 3.2 + devise 2.1.2 app to start. (error included below). I think you are going to have to incorporate this pull request. Devise has changed the way migrations worked since 2.0. This was a pain for devise users as well (https://github.com/plataformatec/devise/wiki/How-To:-Upgrade-to-Devise-2.0-migration-schema-style)

/Users/glongman/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/bundler/gems/devise_openid_authenticatable-35d38335997d/lib/devise_openid_authenticatable/schema.rb:1:in `<top (required)>': uninitialized constant Devise::Schema (NameError)
    from /Users/glongman/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/bundler/gems/devise_openid_authenticatable-35d38335997d/lib/devise_openid_authenticatable.rb:3:in `<top (required)>'
    from /Users/glongman/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/bundler-1.1.5/lib/bundler/runtime.rb:68:in `require'
    from /Users/glongman/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/bundler-1.1.5/lib/bundler/runtime.rb:68:in `block (2 levels) in require'
    from /Users/glongman/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/bundler-1.1.5/lib/bundler/runtime.rb:66:in `each'
    from /Users/glongman/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/bundler-1.1.5/lib/bundler/runtime.rb:66:in `block in require'
    from /Users/glongman/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/bundler-1.1.5/lib/bundler/runtime.rb:55:in `each'
    from /Users/glongman/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/bundler-1.1.5/lib/bundler/runtime.rb:55:in `require'
    from /Users/glongman/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/bundler-1.1.5/lib/bundler.rb:119:in `require'
    from /Users/glongman/Projects/openera_cloud/config/application.rb:7:in `<top (required)>'
    from /Users/glongman/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/railties-3.2.8/lib/rails/commands.rb:39:in `require'
    from /Users/glongman/.rbenv/versions/1.9.3-p194/lib/ruby/gems/1.9.1/gems/railties-3.2.8/lib/rails/commands.rb:39:in `<top (required)>'
    from script/rails:6:in `require'
    from script/rails:6:in `<main>'
nbudin commented 12 years ago

Try it now. I'm using a similar trick that I used in my other gem, devise_cas_authenticatable, to support Devise >= 2.1 with schema support for older versions.

glongman commented 12 years ago

worked for me. ship it!

thanks.

Geoff

nbudin commented 12 years ago

This fix is now released as version 1.1.1. Thanks @msaffitz and @glongman!