search

nbudin / devise_openid_authenticatable

OpenID authentication for Devise
MIT License
99 stars 32 forks source link

Subtle improvement #23

Closed munkius closed 8 years ago

munkius commented 8 years ago

Switching the operation concerning openid_fields for a subtle improvement.

nbudin commented 8 years ago

Just to clarify: I assume the subtle improvement is that this provides a performance benefit in cases where the operation isn't applicable, because a respond_to? check is less expensive than fetching the fields?

munkius commented 8 years ago

Sorry, totally missed your response!

It's indeed that. Why bother to call the fields function when the resource does not implement the function.

nbudin commented 8 years ago

OK great, thanks for clarifying @munkius!

nbudin commented 8 years ago

Released 1.2.1 with this change.