nbudin / google4r-checkout

Google Checkout library for Ruby
http://code.google.com/p/google-checkout-ruby-sample-code/
Other
39 stars 10 forks source link

Notification History Requests #1

Closed danhigham closed 13 years ago

danhigham commented 13 years ago

Hi there, I forked this repository and have added the ability to make Notification History Requests, for example

serial_number = params["serial_number"] notification = Notification.new :serial_number => serial_number

frontend = Frontend.new(FRONTEND_CONFIGURATION) command = frontend.create_notification_history_request_command serial_number result = command.send_to_google_checkout

case result.class when NewOrderNotification

New order notification

when OrderStateChangeNotification

Order state change

else

Just ignore anything else

end

nbudin commented 13 years ago

Thanks very much! I've pulled your changes into master.

Before making a release of this, I'd like to add some tests to the unit test suite for this feature. Would you mind adding some in your fork? (If you don't have time, just let me know and I'll be happy to write them myself once I get a chance, but that won't be for at least a few days.)

danhigham commented 13 years ago

No problems, I hope to get those done today..