nbudin / google4r-checkout

Google Checkout library for Ruby
http://code.google.com/p/google-checkout-ruby-sample-code/
Other
39 stars 10 forks source link

Create Subscriptions/Recurrent Items from XML Elements #13

Closed jamesmartin closed 12 years ago

jamesmartin commented 12 years ago

While testing Subscriptions against the sandbox I noticed that Subscription#create_from_element was calling Item#create_from_element without passing the shopping cart, which causes ArgumentError: wrong number of arguments (1 for 2) to be thrown from deep inside shared.rb.

I fixed the incorrect usage and added a test case for Item::Subscription#create_from_element.

nbudin commented 12 years ago

Thanks again James! Will merge this and release it assuming I can't find any issues.