Add Polling API - Githubissues

nbudin / google4r-checkout

Google Checkout library for Ruby

http://code.google.com/p/google-checkout-ruby-sample-code/

Other

39 stars 10 forks source link

Add Polling API #16

Closed chancedowns closed 11 years ago

chancedowns commented 11 years ago

I've added the Polling API from https://developers.google.com/checkout/developer/Google_Checkout_Beta_Polling_API This API allows you to retrieve all notifications that are less than 180 days old and that are at least 30 minutes old.

nbudin commented 11 years ago

Hi @chancedowns, I'm sorry for taking so long to review this patch.

It seems like commit df204156 is causing some tests to fail by putting private data strings uner a :merchant_note hash key. Could you explain the reasoning for making this change? I think it is possible it will cause some apps issues as well, since it's an API-breaking change.

chancedowns commented 11 years ago

The merchant note was being used to pull out data but it appears that it is not necessary so we've removed it.

nbudin commented 11 years ago

OK, thanks! I've merged this and will release shortly as version 1.2.0.