search

nbudin / google4r-checkout

Google Checkout library for Ruby
http://code.google.com/p/google-checkout-ruby-sample-code/
Other
39 stars 10 forks source link

Added support for 3rd party conversion tracking #2

Closed jniziol closed 13 years ago

jniziol commented 13 years ago

We use a lot of conversion tracking in our applications, so I need a way to support this while using Google Checkout but noticed it wasn't implemented, so I added it.

nbudin commented 13 years ago

Thanks! And especially thanks for including unit tests!

But it looks like you may have accidentally included your sandbox authentication credentials in the commit. Would you mind removing those (and you probably want to scrub them from your commit history as well)?

jniziol commented 13 years ago

I updated the commit, and removed the frontend_configuration. Thanks for the heads up on that one, totally forgot! :) I'm not sure if the SHA for that commit has changed since I essentially removed it and re-added it.

nbudin commented 13 years ago

It looks like Github got confused and auto-closed this pull request (not sure what else it could have done really). I'll attempt to pull directly from your fork.

nbudin commented 13 years ago

Hmm, I'm still seeing frontend_configuration.rb in your tree:

https://github.com/jniziol/google4r-checkout/blob/master/test/frontend_configuration.rb