search

nbusseneau / hephaistos

Supergiant Games' Hades mod adding support for ultrawide monitors (21:9, 32:9), multi-monitor (48:9), Steam Deck (16:10), and custom resolutions.
MIT License
223 stars 4 forks source link

Controller selection in menus not working properly on very wide aspect ratios #10

Closed jpr53196 closed 2 years ago

jpr53196 commented 2 years ago

There is a bug where it will not let you select different options with controller in different menus. One of these is the opening menu at game launch.

nbusseneau commented 2 years ago

Hi, I can't reproduce this bug (using Xbox 360 controller: all menus seem to work fine). Can you try to uninstall all mods you have, verify the game files on Steam / Epic Games to make sure the base game is valid, then install only Hephaistos and check if the issue still happens?

If yes, can you give more details about how to reproduce the issue? Or perhaps a video?

nbusseneau commented 2 years ago

Closing as I can't reproduce this, please provide more information if it still happens :)

pressRtowin commented 2 years ago

Hi, I can't reproduce this bug (using Xbox 360 controller: all menus seem to work fine). Can you try to uninstall all mods you have, verify the game files on Steam / Epic Games to make sure the base game is valid, then install only Hephaistos and check if the issue still happens?

If yes, can you give more details about how to reproduce the issue? Or perhaps a video?

Were you testing in surround resolutions? I've seen this bug happen firsthand on a clean installation

nbusseneau commented 2 years ago

I don't have NVIDIA Surround. Can you share more details on your setup and how to reproduce? Resolution used, what is expected to happen and what happens instead, etc. A video would be ideal :)

pressRtowin commented 2 years ago

I'm not able to at the moment, but we're using 3 1440p displays. It happened with and without bezel correction, so the extra ~200 pixels didn't make a difference in that regard.

I'm not familiar with the game so I don't know the exact terminology. I don't recall the menu screen itself, but there were some menus from within the game itself (triggered when interacting with shops/NPCs/other interfaces) that contained items that could not be selected when using the controller. Mouse control worked fine. It happened when both using and not using the UI remapping option. Disabling the mod immediately restored intended functionality. IIRC it looked like a shop screen or something. There were items(?) in a grid above and different options on a bar at the bottom. The controller could select things up and down, but not left and right. We tried using Steam Input as well with the same results.

If it's purely an aspect ratio problem, you may be able to reproduce it by just going with an extremely narrow custom windowed or borderless resolution within your single display (such as 2560x480 or 1920x360). Otherwise, you may need the full resolution to reproduce.

pressRtowin commented 2 years ago

I think there were some weird UI issues too? The overlay that shows what was selected may have been off to the side rather than on top of what's being selected, but I'm hazy on that. But I remember thinking it could've been something to do with how the game determines what the object to the left and right (which should be selected when left or right is input) actually is, and that glitching out due to the resolution.

pressRtowin commented 2 years ago

https://cdn.vox-cdn.com/thumbor/Dh8otvDf3Oq9RVDxpqmcYzrDHGE=/1400x0/filters:no_upscale()/cdn.vox-cdn.com/uploads/chorus_asset/file/21912450/Hades_Screenshot_2020.09.25___14.06.06.24.png

^ that is one of the menus where it was happening. You can select up and down, but not left and right with a controller, but the mouse works as expected.

nbusseneau commented 2 years ago

Thanks, I have reproduced the issue. This indeed only happens above a certain aspect ratio, it does not happen at 21:9, happens partially at 32:9 on the very far right, and happens anywhere at 48:9.

nbusseneau commented 2 years ago

I strongly suspect there is a sort of "visual pointer" when in controller mode that's based off of the default 1920x1080 viewport, and thus does not work when the menus are moved too far off from the original viewport (which is the case on the very right for 32:9 and basically anywhere for 48:9).

nbusseneau commented 2 years ago

This should be fixed by dc43de769ef205bf430df638afbb83540234fc93. The fix has been released in v1.5.1. Hope that fixes it on your end as well! :D

pressRtowin commented 2 years ago

tested and it works. Thanks!