search

ncannasse / hxsl

Haxe Shader Language, a high level 3D shader language for Haxe
86 stars 10 forks source link

Recent hxformat release breaks hxsl #36

Closed aduros closed 10 years ago

aduros commented 10 years ago 
/home/bruno/.haxe/lib/hxsl/2,0,3/hxsl/AgalCompiler.hx:178: lines 178-181 : Object requires field version
/home/bruno/.haxe/lib/hxsl/2,0,3/hxsl/AgalCompiler.hx:120: lines 120-182 : Missing return format.agal.Data

This breaks new Flambe installs and anything else that depends on hxsl. :(

Do you think you could explicitly specify the dependency version in haxelib.json to prevent this from happening again in the future?

SavedByZero commented 10 years ago

Adding "version : 0" to the return object that throws the first error fixes this, but who knows how permanent that solution is. I'm guessing the version property became obsolete, but the code that checks for it elsewhere did not.

ncannasse commented 10 years ago

With latest format and hxsl, everything should work correctly now.

aduros commented 10 years ago

Do you think you could still specify the required format version in haxelib.json? hxsl simply doesn't work with anything before 3.1.0, so it should specify that.

I think that would also fix flambe/hxsl update issues not pulling down the new format version: https://groups.google.com/forum/#!msg/flambe/ErLdE9lRVdg/TFBp5wf4cqoJ

ncannasse commented 10 years ago

Well, installing the latest hxsl should install the latest format as well.

aduros commented 10 years ago

It looks like it is installed, but the .current file isn't updating to point at the new version. Changing hxsl to specify the version seems to fix it in that case.

This affects users upgrading from flambe 4.0.0 to 4.1.0 (aduros/flambe#293).

ncannasse commented 10 years ago

Uhm, that's not normal behavior. Does it affects only people that had installed the hxsl that explicitely defined the format version ? Usually haxelib would updrade all the dependencies