ncapdevi / FragNav

An Android library for managing multiple stacks of fragments
1.5k stars 220 forks source link

Request upgrade to Android X #161

Closed tcqq closed 5 years ago

tcqq commented 6 years ago

@ncapdevi Request to upgrade FragNav to Android X

Because the support library and the androidx library are incompatible, This will lead to multiple errors. Because support is about to be replaced by androidx. image image

Refactor AndroidX URL:

https://android-developers.googleblog.com/2018/05/hello-world-androidx.html https://developer.android.com/studio/preview/features/#androidx_refactoring https://dl.google.com/dl/android/maven2/index.html

image

diareuse commented 6 years ago

You're welcome to create pull request for this. It's simple, you fork this repository. Make changes and then create pull request with your changes. They may not be accepted by the repository owner. However looking at the history of pull requests, it's generally very likely to be accepted.

Have a great day.

tcqq commented 6 years ago

@diareuse Thank you for your reply, I will try it when I have time.

mateherber commented 6 years ago

If you use the android.enableJetifier = true flag in your project gradle plugin will automagically convert all the libraries you use as if it were written for androidX even if the library hasn't yet been migrated.

image

diareuse commented 6 years ago

@mateherber this is true, however as of now it's done in build time, which could significantly increase the total build time. That's why I suspect he's requesting that transition

mateherber commented 6 years ago

I'm not sure about the added build time there but I'd wait for migrating any library (at least the release part) until androidX is final

diareuse commented 6 years ago

That's for sure, +1 for that.

ShurikuS57 commented 6 years ago

AndroidX is final.

JoeKaldas commented 6 years ago

So is there a build that supports androidx?

mateherber commented 6 years ago

Please watch #178

ncapdevi commented 5 years ago

187 will be released in 3.1.0