search

ncapdevi / FragNav

An Android library for managing multiple stacks of fragments
1.5k stars 220 forks source link

Adding reordering option to FragNavTransactionOptions #208

Closed EDLuke closed 5 years ago

EDLuke commented 5 years ago

Shared element transition requires reordering to be true.

Edited FavoritesFragment to see the effect using reordering=true and shared element transition. You can notice the edit text has a fading transition when a new fragment is pushed. The same effect will not appear if reordering=false.

ncapdevi commented 5 years ago

@EDLuke First pass at this looks great! I need to spend a little bit more time with the documentation . but it looks like unless explicitly set, it will stick with the defaults. Thanks for the Improvement, Sample, and explanation. I'll try to get to the PR tonight

EDLuke commented 5 years ago

@ncapdevi have you had the time to take a look at this?

ncapdevi commented 5 years ago

@EDLuke Ah, my apologies! Everything looked good at last check. Will carve out some time this evening to merge and release an update. Thanks for the reminder!

ncapdevi commented 5 years ago

@EDLuke released as 3.3.0