search

ncapdevi / FragNav

An Android library for managing multiple stacks of fragments
1.5k stars 210 forks source link

Option to specify the fragment manager for showing dialogs #221

Open Sdghasemi opened 4 years ago

Sdghasemi commented 4 years ago

Thanks for the marvelous library, such a great help for managing loads of fragments. It'd be great if there was be an option for passing a fragment manager as the dialog parent fm to attach to. A simple and easy use-case example is when you're having multiple fragments inside a parent fragment (referring as currentFrag) (like a view pager kind of situation) and you need to set the interaction listener for the dialog through getParentFragment() method. Currently it's assigned to the so called currentFrag which has to pass listener method calls to its child fragment which is not a neat solution. Thanks in advance.

ncapdevi commented 4 years ago

@Sdghasemi This seems reasonable to me. Would need to actually code it up to make sure there aren't any issues that it would expose, but I see the use case. Hopefully it is something that can be added in the future.

mirjalal commented 3 years ago

Thank you for this lib! Helped me a lot. However, I also faced with that issue. @ncapdevi is there any progress about this?