Closed dougiesquire closed 1 year ago
Thanks for posting @dougiesquire . A PR would be great. Unfortunately ecgtools
is mostly unmaintained at the moment.
I am going to give you maintainer privileges here :)
Actually, I don't think there are any pydantic-related changes need in ecgtools. The issue comes because updates are needed in Intake-ESM, which ecgtools uses. I've opened an issue with Intake-ESM (see https://github.com/intake/intake-esm/issues/617). Once that is resolved, I'll remove the pydantic version pins I added in #162 and close this issue.
Actually (again), my previous post is not correct. There are a few changes needed. I'll make a PR now.
What happened?
Pydantic v2 was released on July 1. Ecgtools uses pydantic, but does not work with pydantic v2. Simply importing ecgtools with pydantic=v2.0 results in an error.
What did you expect to happen?
Able to use ecgtools with pydantic v2
Minimal Complete Verifiable Example
Relevant log output
Anything else we need to know?
This should be a pretty straightforward update. I'm happy to submit a PR if wanted.