ncarlier / dockerfiles

My dockerfiles.
MIT License
52 stars 15 forks source link

With the official private networks ranges #3

Closed jmcabrera closed 7 years ago

jmcabrera commented 7 years ago

From wikipedia, using the full ranges for private networks. These new ranges include the previously set ones.

jmcabrera commented 7 years ago

after-thought: I did not look into how redsocks deals with ipv6...

ncarlier commented 7 years ago

Good point buddy. But I am not confident that is a good idea to remove the 127.0.0.0 line. If you do so I think that a request inside the container on its localhost interface will be redirected through redsocks. This kind of request can be useful for a health check command. Can you check this ?

jmcabrera commented 7 years ago

It will indeed... And it was not my intention, this range should remain UNproxified imho, reverting back this line :)

ncarlier commented 7 years ago

Thanks!