search

ncase / covid-19

COVID-19 Futures, Explained With Playable Simulations
Creative Commons Zero v1.0 Universal
233 stars 106 forks source link

Add French translation #74

Closed LeSeulArtichaut closed 4 years ago

LeSeulArtichaut commented 4 years ago

I'm not sure this is ready yet so I'll mark this as draft and wait for a signal from @cyrilou242 to mark it as ready for review.

Closes #4

bendman commented 4 years ago

I'm guessing it doesn't need to be perfect. If it's 99% there it's better than no French translation, which is what people see now. 😉

LeSeulArtichaut commented 4 years ago

@bendman I agree, but there are also some technical things to consider. Currently, the French translation is hosted by @cyrilou242 and, as I’m unsure whether this can be maintained as a permanent place for the website to live, I wouldn’t want to add a link to it without their approval.

bendman commented 4 years ago

@LeSeulArtichaut Good point... it's also the only link that is not using the base github domain, which is a bit odd. This URL also works: https://cyrilou242.github.io/covid-19/ if that seems more stable, although it is a 304 redirect. @cyrilou242 seems to have been away for a while, so I'm not sure if he is still paying attention to this project anymore. Anyone else can make a public version using github pages instead, like this: https://bendman.github.io/covid-19/

cyrilou242 commented 4 years ago

ok for me !!! sorry I got very very busy and I thought some guys would manage this without me so I did not read the mentions

catheu.tech is my custom domain for github pages and will be valid until 2021-07-11 23:59:59 (at least) so the resources are hosted by github like the others, but feel free to use https://cyrilou242.github.io/covid-19/ if you feel like it

LeSeulArtichaut commented 4 years ago

Rebased on master to resolve the merge conflicts.

catheu.tech is my custom domain for github pages and will be valid until 2021-07-11 23:59:59 (at least) so the resources are hosted by github like the others, but feel free to use https://cyrilou242.github.io/covid-19/ if you feel like it

I think using catheu.tech is fine here, if it expires we can always come back and edit the link. @ncase, if you still want me to change it, please ping me and I'll amend my commit.

ncase commented 4 years ago

Hi! Sorry it took me a while to get around to pulling this, been swamped. Super appreciate y'all taking the time & effort to make this accessible to more folks! Merci beaucoup! 🎉