Closed evyasonov closed 1 year ago
@Nable80 First of all, thanks for the review! Here is my answers
I don't know if it's OK to promote third-party products here, especially a non-free (proprietary) browser. Even if it's acceptable, IMHO it would be fair to mention other translation services, e.g. translate.google.com
I think that it's ok to include a link to Yandex.browser in localization note. Because:
But I can mention google translate too (despite the fact that the quality of google translate is much worse) :)
hookups != hookers
Thanks, will fix!
По-моему, в этой части наблюдается нехватка буквы ё.
According to rules of Russian language it's ok use е
instead of ё
when it does not change the meaning. It does not change the meaning. Will fix if in the rest of the text I use ё
.
запущено
Will fix the typo, thanks!
«дзынь» – сигнал персоналу
Ok, will think. Probably will add «»
обратную, статьи
Will fix the typos, thanks!
Regarding the gender of author – as I mentioned before, I will add an option for readers to choose gender of narrator, so the text will be changed automatically (using vue.js or maybe pure js). Please wait for the next commit, it will be soon.
@ncase @Nable80 Ok, here is the new commit: added gender selection + fixed all @Nable80 comments
@ncase can you please merge & deploy
Awesome, thank you so much @evyasonov and @Nable80, for making this accessible to more folks around the globe! (And dealing with issues I didn't think about re: translating to other languages, like gender pronouns)
Have a great end-of-year! 🎉
Please wait for another commit. Adding gender selection