bug in scrolling "credits" display

ncase / nutshell

Make expandable explanations!

https://ncase.me/nutshell/

Creative Commons Zero v1.0 Universal

518 stars 32 forks source link

bug in scrolling "credits" display #1

Closed mkosma closed 2 years ago

mkosma commented 2 years ago

Hi Nicky!

Monty here (@mkosma). Danielle (@dstrachman) mentioned Nutshell on a call today and I had to check it out.

Minor bug discovered: the scrolling "thanks" display aborts before getting through the C's (around Cristy) and restarts the list. The behavior also occurs on the embedded page (https://ncase.me/thanks/aug2022.html?credits=1).

(I can see the whole list if I remove ?credits=1 from the url.)

Anyway, Nutshell looks very cool ... should be super handy if I can link it into Logseq...

monty

ChildishGiant commented 2 years ago

I can't replicate this on Firefox but I can on Chrome v104 🤔

ncase commented 2 years ago

Hi sorry this took a while! I was, for some reason, only able to replicate this once on Chrome, then it worked as expected since then?

I have no idea what happened, but I suspect it was because my code for the scrolling credits calculated the height of the page once on load. I think maybe it calculated too early, before everything loaded, hence it thought the page's height was shorter. I changed it so it just calculates the page height over and over.

Let me know if the problem was fixed (clear your cache if need be); thank you for catching this!