search

ncassetta / NiCMidi

A MIDI C++ library with objects for reading, writing, playing, editing and recording midi files
GNU Lesser General Public License v3.0
2 stars 1 forks source link

Channel filtering not OK in thru.cpp/.h #9

Closed goofy2k closed 2 years ago

goofy2k commented 2 years ago

To get proper operation with "all channels selected" while using thru, I have to use a comparison with 255 in thru.cpp:193 and 194.

I can use the intended -1 when the definitions of in_channel and out_channel in thru.h:113 and 114 are changed from char to signed char.

ncassetta commented 2 years ago

Fixed in the commit Revised many types