search

ncasuk / amf-check-writer

Library to write AMF compliance checks
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Create a "GlobalAttributesCV" class #18

Closed agstephens closed 3 years ago

agstephens commented 4 years ago

Mirror other classes, DimensionsCV is probably most useful.

We might be able to completely re-use this class:

https://github.com/ncasuk/amf-check-writer/blob/b7dc6aaff7cbac3ec93607da121544ac01a001c6/amf_check_writer/yaml_check.py#L91

Also need to make sure that global attributes worksheets are saved as TSV files in the same way that dimensions-specific and variables-specific are saved, e.g.:

https://github.com/ncasuk/AMF_CVs/tree/master/product-definitions/tsv/moisture-profiles

agstephens commented 3 years ago

@gapintheclouds I think this issue relates to the work that you are currently doing, regarding the GlobalAttrCheck class.

gapintheclouds commented 3 years ago

Yes. This is done now.