ncasuk / amf-check-writer

Library to write AMF compliance checks
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Migrate away from using git submodule (use "roocs" approach) #27

Closed agstephens closed 3 years ago

agstephens commented 4 years ago

Git submodule does behave exactly as we would expect. In particular, the main github repo that holds the submodule, keeps track of the specific commit point on the submodule timeline and binds permanently to that unless you manage it. In order to manage it you might need to:

cd submod/
git checkout master # or other point
cd ../  # back to main repo
git add submod  # to tell it you want to update commit that is used in submodule
git commit -m 'Updated submodule commit point'
git push

See details here:

https://intellipaat.com/community/9971/git-update-submodule-to-latest-commit-on-origin#:~:text=The%20git%20submodule%20update%20command,this%20directly%20within%20the%20submodules.

Maybe it would be easier for us to avoid using submodules. Not sure at the moment.

agstephens commented 4 years ago

We have a proposed better approach used in another project. I'll bring it here.

gapintheclouds commented 3 years ago

In theory we don't need the cc-vocab-cache from the repository as it is created locally form the downloaded spreadsheets using create-cvs.

agstephens commented 3 years ago

Done in PR: https://github.com/cedadev/compliance-check-lib/pull/10

agstephens commented 3 years ago

We can close this when the PR is merged.

agstephens commented 3 years ago

Done.