search

ncasuk / amf-check-writer

Library to write AMF compliance checks
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Write the global attribute handler for specific AMF products #29

Closed agstephens closed 3 years ago

agstephens commented 4 years ago

@gapintheclouds this may overlap with an existing github Issue but just creating it as a reminder to pick up.

gapintheclouds commented 3 years ago

Hi @agstephens ,

On the topic of integrating specific global attribute checks.

I've been trying to work out whether we can/should use the existing GlobalAttrCheck which is used for the overall global attributes instead of creating a separate GlobalAttributesCV. This would be useful to only have one global attribute check creator that can do both the overall and specific global attributes. And then we can access the regex expressions in GlobalAttrCheck. What do you think?

I've been playing with it a bit but wanted to check before I went into the depths.

gapintheclouds commented 3 years ago

@agstephens Think I've sorted it now.

The specific global attributes need to have some compliance checking rules, in the same format as the global global attributes.