Check spreadsheet compliance check rules for data product in v2.0

ncasuk / amf-check-writer

Library to write AMF compliance checks

BSD 3-Clause "New" or "Revised" License

0 stars 4 forks source link

Check spreadsheet compliance check rules for data product in v2.0 #44

Closed agstephens closed 3 years ago

agstephens commented 3 years ago

Updates to spreadsheets (progress):

[x] aerosol-backscatter-radial-winds/global-attributes-specific.tsv
[x] aerosol-size-distribution/global-attributes-specific.tsv (https://docs.google.com/spreadsheets/d/1vB1Pig6fRRT2LfsZXeuPP8gqoLeeHjFoqha6B3IlwsI/edit#gid=1572749845)
[x] boundary-layer-thickness-ceilometer/global-attributes-specific.tsv
[x] cloud-base/global-attributes-specific.tsv
[x] cloud-coverage/global-attributes-specific.tsv
[x] _common/global-attributes.tsv
[x] depolarisation-ratio/global-attributes-specific.tsv
[x] particle-size-distribution/global-attributes-specific.tsv (https://docs.google.com/spreadsheets/d/1EJvC9wEryV7Xub5lr6KFsMZtMd2zN-FgRRdDlsXWUwE/edit#gid=1572749845)
[x] precipitation/global-attributes-specific.tsv (https://docs.google.com/spreadsheets/d/1cKF9fZ5nnYt3y4svGa29enZa6bqcDPiq0Bj0Ok28bJY/edit#gid=232604322)

Three of them still need attention. @barbarabrooks - please can you take a look at those 3.

agstephens commented 3 years ago

Updates to spreadsheets (progress):

[x] aerosol-backscatter-radial-winds/global-attributes-specific.tsv
[x] aerosol-size-distribution/global-attributes-specific.tsv (https://docs.google.com/spreadsheets/d/1vB1Pig6fRRT2LfsZXeuPP8gqoLeeHjFoqha6B3IlwsI/edit#gid=1572749845)
[x] boundary-layer-thickness-ceilometer/global-attributes-specific.tsv
[x] cloud-base/global-attributes-specific.tsv
[x] cloud-coverage/global-attributes-specific.tsv
[x] _common/global-attributes.tsv
[x] depolarisation-ratio/global-attributes-specific.tsv
[x] particle-size-distribution/global-attributes-specific.tsv (https://docs.google.com/spreadsheets/d/1EJvC9wEryV7Xub5lr6KFsMZtMd2zN-FgRRdDlsXWUwE/edit#gid=1572749845)
[x] precipitation/global-attributes-specific.tsv (https://docs.google.com/spreadsheets/d/1cKF9fZ5nnYt3y4svGa29enZa6bqcDPiq0Bj0Ok28bJY/edit#gid=232604322)

Three of them still need attention. @barbarabrooks - please can you take a look at those 3.

agstephens commented 3 years ago

Regarding "precipitation", the relevant global attribute is: measurement_technique

The description is currently:

optical, peizoelectric, tipping_bucket, drop_counting, weighing, collecting, droplet_impact

Should the compliance-check-rule be: "match one of these: optical, peizoelectric, tipping_bucket, drop_counting, weighing, collecting, droplet_impact" ...or should it be simpler, just: "match a string of more than 3 characters"?

agstephens commented 3 years ago

Agreed to set the rule as:

One of: optical, peizoelectric, tipping_bucket, drop_counting, weighing, collecting, droplet_impact

agstephens commented 3 years ago

Before closing this, check that we no longer get any row parsing errors from:

download-from-drive --secrets client-secret.json -v v2.0 $DATA_DIR

agstephens commented 3 years ago

All working now.