search

ncasuk / amf-check-writer

Library to write AMF compliance checks
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Looks like global attribute checks are duplicated #45

Open agstephens opened 3 years ago

agstephens commented 3 years ago

See:

$ diff /vagrant-share/amf-compliance-checker-work-2021/check-data-2021-08-27/yaml_checks/v2.0/AMF_global_attrs.yml  /vagrant-share/amf-compliance-checker-work-2021/check-data-2021-08-27/yaml_checks/v2.0/AMF_product_common_global-attributes_land.yml
1c1
< suite_name: global_attrs_checks:2.0
---
> suite_name: product_common_global-attributes_land_checks:2.0
3c3
< description: Check 'global_attrs' in AMF files
---
> description: Check 'product common global-attributes land' in AMF files

They are the same, but both are referenced in the main check files (land, sea, air and trajectory):

$ grep attr yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_{land,sea,air,trajectory}.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_land.yml:- __INCLUDE__: AMF_global_attrs.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_land.yml:- __INCLUDE__: AMF_product_aerosol-backscatter-radial-winds_global-attributes.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_land.yml:- __INCLUDE__: AMF_product_common_global-attributes_land.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_sea.yml:- __INCLUDE__: AMF_global_attrs.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_sea.yml:- __INCLUDE__: AMF_product_aerosol-backscatter-radial-winds_global-attributes.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_sea.yml:- __INCLUDE__: AMF_product_common_global-attributes_sea.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_air.yml:- __INCLUDE__: AMF_global_attrs.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_air.yml:- __INCLUDE__: AMF_product_aerosol-backscatter-radial-winds_global-attributes.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_air.yml:- __INCLUDE__: AMF_product_common_global-attributes_air.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_trajectory.yml:- __INCLUDE__: AMF_global_attrs.yml
yaml_checks/v2.0/AMF_product_aerosol-backscatter-radial-winds_trajectory.yml:- __INCLUDE__: AMF_product_aerosol-backscatter-radial-winds_global-att

We need to work out which one should be favoured.