search

ncatlab / nlab

Source code for the nLab
https://ncatlab.org
149 stars 16 forks source link

Replace stored files hack for failed edits with Rails session store. #34

Closed sattlerc closed 8 months ago

sattlerc commented 8 months ago

Fixes ncatlab/nlab-deployment#187.

felixwellen commented 8 months ago

I can see there is some risk for data loss, since the announcement field (and the edit-field?) could be overwritten unnoticed. To really review this, I would have to invest some time I won't have in the near future. Is it worth it to wait that long? It might be a lot faster if we find some time to discuss this change in person. Otherwise I am certainly for abandoning the hackish way of storing the announcement in a file.

sattlerc commented 8 months ago

Merging after discussing in person.