ncats / CTSA-Metrics

17 stars 16 forks source link

Inconsistent date literal on line 78 will cause script maintenance issues in the future #36

Open DarrenWHenderson opened 3 years ago

DarrenWHenderson commented 3 years ago

https://github.com/ncats/CTSA-Metrics/blob/17e92435884d00bb0dd2f3f5a8d683151787e38f/InformaticsMetricACTSQLServer.sql#L78

The date literal '2020/01/01' on line 78 is the only time the floor for the one-year census period is written in yyyy/mm/dd format in the entire script. It will make find-replace in future maintenance of the script fail.