search

ncats / RDAS

5 stars 6 forks source link

Merge JournalVolume nodes with Journal nodes #21

Closed qianzhu2018 closed 9 months ago

qianzhu2018 commented 2 years ago

Currently there is one class named JournalVolume and one Journal class, it doesn't make sense we have these two separate classes, can we merge JournalVolume to Journal?

brandon-gong commented 2 years ago

It appears that Journal are groups of JournalVolumes with shared ESSN/ISSN/medlineAbbreviation/nlmid/title. Is this not a useful way to group articles together in a hierarchical manner?

If we do merge JournalVolume to Journal, should we then copy the attributes from Journal into each connected JournalVolume so we don't lose this information? i.e. new Journal nodes would have essn, issn, medlineAbbreviation, nlmid, title, dateOfPublication, issue, journalIssueId, monthOfPublication, printPublicationDate, volume, and yearOfPublication properties?

qianzhu2018 commented 2 years ago

Leave it there for now, might be come back later